<div style="text-align:center"></div><div>
<p><a href="https://make.wordpress.org/core/2023/05/16/performance-chat-agenda-16-may-2023/">Meeting agenda here</a> and the full chat log is available <a href="https://wordpress.slack.com/archives/C02KGN5K076/p1684249208337179">beginning here on Slack</a>.</p>
<h2 class="wp-block-heading">Announcements</h2>
<ul>
<li>Yesterday saw <a href="https://github.com/WordPress/performance/releases/tag/2.3.0">version 2.3.0</a> of the Performance Lab plugin released</li>
</ul>
<h2 class="wp-block-heading" id="focus-group-updates">Priority Projects</h2>
<h3 class="wp-block-heading" id="images">Server Response Time</h3>
<p><a href="https://make.wordpress.org/performance/roadmap-2023/#category-server-response-time">Link to roadmap projects</a></p>
<p>Contributors: <a href="https://profiles.wordpress.org/joemcgill/" class="mention"><span class="mentions-prefix">@</span>joemcgill</a> <a href="https://profiles.wordpress.org/spacedmonkey/" class="mention"><span class="mentions-prefix">@</span>spacedmonkey</a> <a href="https://profiles.wordpress.org/aristath/" class="mention"><span class="mentions-prefix">@</span>aristath</a></p>
<ul>
<li><a href="https://profiles.wordpress.org/aristath/" class="mention"><span class="mentions-prefix">@</span>aristath</a> <a rel="noreferrer noopener" href="https://github.com/WordPress/wordpress-develop/pull/3470" target="_blank">Autoloading PHP classes in WP</a>: I’ve been doing some tests and it looks like this PR improves server response times a bit. More importantly though, it reduces memory usage so that’s a big win. The only “controversial” thing about that PR is that it allows users to override Core classes if they load their own classes with the same name early enough.
<ul>
<li>Pros: <strong>No more user hacks in Core files!</strong> If users want to override a class in Core, it will be possible. There are many valid reasons and scenarios to do that, since not everything in Core is filterable. What that means is that users will no longer resort to editing Core files directly to do what they need to do – and therefore they will be able to update their sites normally. Responsibility to maintain their own personal overrides falls to them. Maintain your own hacks.</li>
<li>Cons: It’s going to be a tough sell.</li>
<li><a href="https://profiles.wordpress.org/joemcgill/" class="mention"><span class="mentions-prefix">@</span>joemcgill</a> Amazing work to see. Would be useful to know what support or feedback <a href="https://profiles.wordpress.org/aristath/" class="mention"><span class="mentions-prefix">@</span>aristath</a> wants from us to keep this moving forward.</li>
</ul>
</li>
<li><a href="https://profiles.wordpress.org/spacedmonkey/" class="mention"><span class="mentions-prefix">@</span>spacedmonkey</a> just created this ticket <a href="https://core.trac.wordpress.org/ticket/58327">#58327</a></li>
<li><a href="https://profiles.wordpress.org/spacedmonkey/" class="mention"><span class="mentions-prefix">@</span>spacedmonkey</a> PRs in need of review
<ul>
<li><a rel="noreferrer noopener" aria-describedby="qtip-92" href="https://github.com/WordPress/wordpress-develop/pull/4459" target="_blank">https://github.com/WordPress/wordpress-develop/pull/4459</a></li>
<li><a rel="noreferrer noopener" href="https://github.com/WordPress/wordpress-develop/pull/4456" target="_blank">https://github.com/WordPress/wordpress-develop/pull/4456</a></li>
<li><a rel="noreferrer noopener" href="https://github.com/WordPress/wordpress-develop/pull/4455" target="_blank">https://github.com/WordPress/wordpress-develop/pull/4455</a></li>
</ul>
</li>
<li><a href="https://profiles.wordpress.org/joemcgill/" class="mention"><span class="mentions-prefix">@</span>joemcgill</a> For our goal, <strong>Identifying and addressing the largest server response time bottlenecks in WordPress core – </strong>I’ve drafted a blog post summarizing the performance analysis I did of WP 6.2 and plan to post it this week after getting a few eyes on it. <a href="https://profiles.wordpress.org/spacedmonkey/" class="mention"><span class="mentions-prefix">@</span>spacedmonkey</a> who has been an early reviewer and contributor to this work has already been busy spinning up tickets for some of what was discovered.
<ul>
<li><a href="https://profiles.wordpress.org/spacedmonkey/" class="mention"><span class="mentions-prefix">@</span>spacedmonkey</a> The PRs listed above are the “flow hanging fruit” from the review</li>
</ul>
</li>
</ul>
<h3 class="wp-block-heading" id="images">Database Optimization</h3>
<p><a href="https://make.wordpress.org/performance/roadmap-2023/#category-database-optimization">Link to roadmap projects</a></p>
<p>Contributors: <a href="https://profiles.wordpress.org/aristath/" class="mention"><span class="mentions-prefix">@</span>aristath</a> <a href="https://profiles.wordpress.org/spacedmonkey/" class="mention"><span class="mentions-prefix">@</span>spacedmonkey</a> <a href="https://profiles.wordpress.org/olliejones/" class="mention"><span class="mentions-prefix">@</span>olliejones</a> <a href="https://profiles.wordpress.org/rjasdfiii/" class="mention"><span class="mentions-prefix">@</span>rjasdfiii</a></p>
<ul>
<li><a href="https://profiles.wordpress.org/spacedmonkey/" class="mention"><span class="mentions-prefix">@</span>spacedmonkey</a> Committed
<ul>
<li><a href="https://github.com/WordPress/wordpress-develop/commit/1a5b52a17e0bfa1ca2d9133466b5ead098e3a1ba">https://github.com/WordPress/wordpress-develop/commit/1a5b52a17e0bfa1ca2d9133466b5ead098e3a1ba</a></li>
<li><a href="https://github.com/WordPress/wordpress-develop/commit/3114eda235d6740f82fc9f2b4bdf0735e43560ed">https://github.com/WordPress/wordpress-develop/commit/3114eda235d6740f82fc9f2b4bdf0735e43560ed</a></li>
<li><a href="https://github.com/WordPress/wordpress-develop/commit/4313210c8232cd7961f9da9660636623319070e8">https://github.com/WordPress/wordpress-develop/commit/4313210c8232cd7961f9da9660636623319070e8</a></li>
<li>These are the final commits for my project to lazy load as much meta data as possible. Term, comment and site meta now always lazy load.</li>
</ul>
</li>
</ul>
<h3 class="wp-block-heading" id="object-caching">JavaScript &#038; CSS</h3>
<p><a href="https://make.wordpress.org/performance/roadmap-2023/#category-javascript-css">Link to roadmap project</a></p>
<p>Contributors: <a href="https://profiles.wordpress.org/mukesh27/" class="mention"><span class="mentions-prefix">@</span>mukesh27</a> <a href="https://profiles.wordpress.org/10upsimon/" class="mention"><span class="mentions-prefix">@</span>10upsimon</a> <a href="https://profiles.wordpress.org/adamsilverstein/" class="mention"><span class="mentions-prefix">@</span>adamsilverstein</a></p>
<ul>
<li><a href="https://profiles.wordpress.org/joemcgill/" class="mention"><span class="mentions-prefix">@</span>joemcgill</a> We’re continuing to track and respond to feedback on the <a rel="noreferrer noopener" href="https://core.trac.wordpress.org/ticket/12009" target="_blank">Trac ticket</a> for adding support for script loading strategies to core. I’ve been focused on trying to get consensus with @azaozz about the open question about how to best support <code>async</code>, and in the meantime, <a href="https://profiles.wordpress.org/10upsimon/" class="mention"><span class="mentions-prefix">@</span>10upsimon</a> has been reviewing and responding to other feedback, <a href="https://profiles.wordpress.org/10upsimon/" class="mention"><span class="mentions-prefix">@</span>10upsimon</a> anything to add?</li>
<li><a href="https://profiles.wordpress.org/10upsimon/" class="mention"><span class="mentions-prefix">@</span>10upsimon</a> I am addressing lower hanging fruit regarding test cases, adding <code>@covers</code> to tests, and adding failure messages. Regarding <code>@covers</code> it is generally unclear which methods and functions I should be adding, as even though we may test something as simple as an inline script in the after position attached to a deferred script, there are many functions in the logic chain that are affected, such as WP_Scripts::do_item, WP_Scripts::get_eligible_loading_strategy etc. Do we add all, some, mose affected etc? <a href="https://profiles.wordpress.org/spacedmonkey/" class="mention"><span class="mentions-prefix">@</span>spacedmonkey</a> this is probably more a discussion with you.
<ul>
<li><a href="https://profiles.wordpress.org/joemcgill/" class="mention"><span class="mentions-prefix">@</span>joemcgill</a> Right. I know the WP Core Handbook now has a recommendation to include <code>@covers</code>, but I’m not aware of any specific best practices that have been documented, so some discussion here would be helpful.</li>
<li><a href="https://profiles.wordpress.org/westonruter/" class="mention"><span class="mentions-prefix">@</span>westonruter</a> AFAIK the gist of it is if a given test touches a given function/method, you can add <code>@covers</code> to explicitly state those are being tested. (Not clear to me why this can’t be automatically detected though)</li>
<li><a href="https://profiles.wordpress.org/spacedmonkey/" class="mention"><span class="mentions-prefix">@</span>spacedmonkey</a> Covers is to note what the test covers. What method or function are you testing in this test.</li>
<li><a href="https://profiles.wordpress.org/10upsimon/" class="mention"><span class="mentions-prefix">@</span>10upsimon</a> So it should include no methods or functions not explicitly visible in the test function?</li>
<li><a href="https://profiles.wordpress.org/joemcgill/" class="mention"><span class="mentions-prefix">@</span>joemcgill</a> Official PHPUnit docs is here: <a rel="noreferrer noopener" href="https://docs.phpunit.de/en/8.5/annotations.html#appendixes-annotations-covers-tables-annotations" target="_blank">https://docs.phpunit.de/en/8.5/annotations.html#appendixes-annotations-covers-tables-annotations</a></li>
</ul>
<ul>
<li>Note that the docs explicitly state: This will make sure that code is only marked as covered if there are dedicated tests for it, but not if it used indirectly by the tests for a different class, thus avoiding false positives for code coverage</li>
<li><a href="https://profiles.wordpress.org/spacedmonkey/" class="mention"><span class="mentions-prefix">@</span>spacedmonkey</a> Every new method or function should have a test covering it. That is the point of unit tests, to see what is / isnt covered.</li>
<li><a href="https://profiles.wordpress.org/10upsimon/" class="mention"><span class="mentions-prefix">@</span>10upsimon</a> Sure, and they do, but we have some tests that are so reliant on – for example – other methods in the chain that are critical to the outcome of the test, but not called directly in the test. A good example is WP_Scripts::do_item and WP_Scripts::get_eligible_loading_strategy, but given that these have dedicated tests, it appears as though adding them via <code>@covers</code> is not needed at all, only against tests solely created for their coverage.</li>
<li><a href="https://profiles.wordpress.org/spacedmonkey/" class="mention"><span class="mentions-prefix">@</span>spacedmonkey</a> You can have multiple covers comments if you want. It is common to do this in core, as lots of wrapper functions call an class. It makes sense to mark the class / method and function as covers.</li>
<li><a href="https://profiles.wordpress.org/10upsimon/" class="mention"><span class="mentions-prefix">@</span>10upsimon</a> ^^ This is where the lines get blurred to me, this is what I have done in a recent PR that I will link to from your PR feedback, I’m just not sure where the buck should stop. Let’s pick this up in the PR itself.</li>
</ul>
</li>
<li><a href="https://profiles.wordpress.org/10upsimon/" class="mention"><span class="mentions-prefix">@</span>10upsimon</a> I’m addressing <a href="https://profiles.wordpress.org/westonruter/" class="mention"><span class="mentions-prefix">@</span>westonruter</a> CSP feedback as next priority, which will also result in changes to the test suite</li>
</ul>
<h3 class="wp-block-heading" id="measurement">Images</h3>
<p><a href="https://make.wordpress.org/performance/roadmap-2023/#category-images">Link to roadmap projects</a></p>
<p>Contributors: <a href="https://profiles.wordpress.org/flixos90/" class="mention"><span class="mentions-prefix">@</span>flixos90</a> <a href="https://profiles.wordpress.org/thekt12/" class="mention"><span class="mentions-prefix">@</span>thekt12</a> <a href="https://profiles.wordpress.org/adamsilverstein/" class="mention"><span class="mentions-prefix">@</span>adamsilverstein</a> <a href="https://profiles.wordpress.org/joemcgill/" class="mention"><span class="mentions-prefix">@</span>joemcgill</a></p>
<ul>
<li><a href="https://profiles.wordpress.org/clarkeemily/" class="mention"><span class="mentions-prefix">@</span>clarkeemily</a> work has been progressing on ‘More accurate lazy-loading’
<ul>
<li><a href="https://profiles.wordpress.org/joemcgill/" class="mention"><span class="mentions-prefix">@</span>joemcgill</a> The following PRs have been opened related to and could use eyes:</li>
</ul>
<ul>
<li><a rel="noreferrer noopener" href="https://github.com/WordPress/wordpress-develop/pull/4424" target="_blank">https://github.com/WordPress/wordpress-develop/pull/4424</a></li>
<li><a target="_blank" href="https://github.com/WordPress/wordpress-develop/pull/4428" rel="noreferrer noopener">https://github.com/WordPress/wordpress-develop/pull/4428</a></li>
<li><a target="_blank" href="https://github.com/WordPress/wordpress-develop/pull/4300" rel="noreferrer noopener">https://github.com/WordPress/wordpress-develop/pull/4300</a></li>
<li><a target="_blank" href="https://github.com/WordPress/wordpress-develop/pull/4390" rel="noreferrer noopener">https://github.com/WordPress/wordpress-develop/pull/4390</a></li>
<li><a rel="noreferrer noopener" href="https://github.com/WordPress/wordpress-develop/pull/4439" target="_blank">https://github.com/WordPress/wordpress-develop/pull/4439</a></li>
</ul>
</li>
<li><a href="https://profiles.wordpress.org/flixos90/" class="mention"><span class="mentions-prefix">@</span>flixos90</a> Yes, I’m planning to commit <a rel="noreferrer noopener" href="https://core.trac.wordpress.org/ticket/58213" target="_blank">https://core.trac.wordpress.org/ticket/58213</a> (the above PR 4428) today. Any feedback on the other PRs is much appreciated. I’ll also follow up on the latest feedback that came in in the past couple hours</li>
</ul>
<h3 class="wp-block-heading" id="javascript">Measurement</h3>
<p><a href="https://make.wordpress.org/performance/roadmap-2023/#category-measurement">Link to roadmap projects</a></p>
<p>Contributors: <a href="https://profiles.wordpress.org/adamsilverstein/" class="mention"><span class="mentions-prefix">@</span>adamsilverstein</a> <a href="https://profiles.wordpress.org/olliejones/" class="mention"><span class="mentions-prefix">@</span>olliejones</a> <a href="https://profiles.wordpress.org/joemcgill/" class="mention"><span class="mentions-prefix">@</span>joemcgill</a> <a href="https://profiles.wordpress.org/mukesh27/" class="mention"><span class="mentions-prefix">@</span>mukesh27</a></p>
<ul>
<li>No updates this week</li>
</ul>
<h3 class="wp-block-heading">Ecosystem Tools</h3>
<p><a href="https://make.wordpress.org/performance/roadmap-2023/#category-ecosystem-tools">Link to roadmap projects</a></p>
<p>Contributors: <a href="https://profiles.wordpress.org/joegrainger/" class="mention"><span class="mentions-prefix">@</span>joegrainger</a></p>
<ul>
<li><a href="https://profiles.wordpress.org/mukesh27/" class="mention"><span class="mentions-prefix">@</span>mukesh27</a> I am currently working on some of the issues for Plugin Checker, and there are some PRs ready for review at <a rel="noreferrer noopener" href="https://github.com/10up/plugin-check/pulls/mukeshpanchal27" target="_blank">https://github.com/10up/plugin-check/pulls/mukeshpanchal27</a>, If anyone has capacity please review it. Thanks!</li>
<li>@joegrainer We are working on some of the final issues for the <a rel="noreferrer noopener" href="https://github.com/10up/plugin-check/" target="_blank">Plugin Checker</a> that came out of the Review/QA. This brings in some bug fixes and other enhancements as we work towards an initial release. You can follow the progress on the <a rel="noreferrer noopener" href="https://github.com/10up/plugin-check/" target="_blank">GitHub repo</a> here. Thanks!</li>
</ul>
<h3 class="wp-block-heading" id="infrastructure">Creating Standalone Plugins</h3>
<p><a href="https://github.com/WordPress/performance/issues/656">Link to GitHub overview issue</a></p>
<p>Contributors: <a href="https://profiles.wordpress.org/flixos90/" class="mention"><span class="mentions-prefix">@</span>flixos90</a> <a href="https://profiles.wordpress.org/mukesh27/" class="mention"><span class="mentions-prefix">@</span>mukesh27</a> <a href="https://profiles.wordpress.org/10upsimon/" class="mention"><span class="mentions-prefix">@</span>10upsimon</a></p>
<ul>
<li>No updates this week</li>
</ul>
<h1 class="wp-block-heading">Open Floor</h1>
<ul>
<li><a href="https://profiles.wordpress.org/spacedmonkey/" class="mention"><span class="mentions-prefix">@</span>spacedmonkey</a> This discussion has been very active – <a rel="noreferrer noopener" href="https://github.com/WordPress/performance/issues/403" target="_blank">https://github.com/WordPress/performance/issues/403</a> Interested parties should take a look</li>
</ul>
<p><strong>Our next chat will be held on <a href="https://www.timeanddate.com/worldclock/fixedtime.html?iso=20230523T1500"><abbr class="date" title="2023-05-23T15:00:00+00:00">Tuesday, May 23, 2023 at 15:00 UTC</abbr></a> in the <a href="https://wordpress.slack.com/messages/core-performance/">#core-performance channel</a> in <a href="https://make.wordpress.org/chat/">Slack</a>.</strong></p>
<p class="o2-appended-tags"><a href="https://make.wordpress.org/core/tag/core-performance/" class="tag"><span class="tag-prefix">#</span>core-performance</a>, <a href="https://make.wordpress.org/core/tag/performance/" class="tag"><span class="tag-prefix">#</span>performance</a>, <a href="https://make.wordpress.org/core/tag/performance-chat/" class="tag"><span class="tag-prefix">#</span>performance-chat</a>, <a href="https://make.wordpress.org/core/tag/summary/" class="tag"><span class="tag-prefix">#</span>summary</a></p>
</div>

As October winds down, so too does Blocktober, Tammie Lister’s month-long challenge to create a…
The WordPress Foundation and WooCommerce have joined Automattic and Matt Mullenweg in countersuing WP Engine,…
The first-ever CloudFest USA Hackathon, taking place November 4 in Miami, will bring together contributors…
Canada’s largest gathering of WordPress enthusiasts drew a strong turnout at Carleton University last weekend,…
WooCommerce 10.3 was released this week, introducing one of the most requested features for store…
Automattic has hired GiveWP co-founder Devin Walker as Artistic Director for Jetpack, where he will…