Performance Chat Summary: 7 May 2024
Meeting agenda here and the full chat log is available beginning here on Slack.
Announcements
- Welcome to our new members of #core-performance
Priority Items
Structure:
- WordPress performance Trac tickets
- Current release (WP 6.6)
- Performance Lab plugin (and other performance plugins)
- Active priority projects
- Improve template loading
- INP research opportunities
- Improving the calculation of image size attributes
- Optimized autoloaded options
WordPress Performance Trac Tickets
- For WordPress 6.6:
- No updates today, watch out for the bug scrub happening tomorrow
Performance Lab Plugin (and other Performance Plugins)
- @westonruter I think we’re just about done with the PHPStan level upgrades, going from 0 to 6: https://github.com/WordPress/performance/issues/775
- The team continued to discuss the number of levels and also #59653
- @westonruter It would be great for core to adopt it with a populated baseline so that all existing issues are ignored but new issues are reported as they arise
- @joemcgill The PHPStan work will likely cause bumps to all of our plugins, not just the ones with issues in milestones. Are those going to be reflected in changelogs?
- @westonruter Yeah, we need to bump the versions. Maybe a general changelog entry for improving code quality?
- @joemcgill That makes sense, we can even add the overarching ticket to all the project milestones perhaps?
- @johnbillion RE PHPStan, core ticket #52217 is about fixing issues it identified, but I would be in favour of a follow-up proposing implementing PHPStan at some level.
- @westonruter will file a ticket
- @clarkeemily reminder that the next Performance Lab release is May 20 see https://github.com/WordPress/performance/milestones
Active Priority Projects
Improve template loading
- @joemcgill three issues remaining in this project, #59595, #59600, and #57789
- #61112 is related to the above, and looks ready for commit to both Gutenberg and Core. I don’t have commit access to GB but can handle the Core merge
- @joemcgill All this need to make the same change in both repos seems inefficient to me, and is part of the larger conversation about improving the syncing process from GB > WP-dev repos. I’ve started this thread specifically about improving the way the theme.json stuff is managed
- @joemcgill I think we can handle the
isGlobalStylesUserThemeJSON
change in a follow-up pending discussion in the GB repo - @thekt12 Yes. But do we need to fix inconstancy in core PR now or we should do it after the next GB pr?
- @joemcgill No, that needs to be fixed when the change in the GB repo is synced to Core. That’s why the inconsistency exists, and highlights the problem with maintaining redundant classes in both repos.
- @joemcgill I think we can handle the
- @thekt12 working on improvements to #59595
INP research opportunities
- GitHub tracking issue
- @adamsilverstein I’ve been working a little on adding instrumentation to the Interactivity API in a draft PR
Improving the calculation of image size attributes
- @joemcgill No changes since last week, but are planning to start development on #GH1187 soon
Optimized autoloaded options
- @joemcgill Yesterday, I committed r58105, which is a follow-up on our previous autoload options changes
- As a side effect, it revealed that there are some issues with the way we are collecting performance metrics in the codevitals dashboard that I plan to follow up on later today
- Also @pbearne and I have been collaborating on a dev note for r57920, which is close to being ready for review.
Open Floor
- @mukesh27 Is there any plan to merge https://github.com/WordPress/performance/tree/trunk/includes/site-health/audit-autoloaded-options in core?
- @spacedmonkey The blocker for the above was at the lack of action to.
- it is all well and good highlighting that there are 20 options that are very large, but with no way to fix it, a user it out of luck. I had planned to have a way of changing options to be from being autoloaded or not. Think checkbox and rest api to update the row in the database. I haven’t had anytime to look at now I am not sponsored.
Our next chat will be held on Tuesday, May 14, 2024 at 15:00 UTC in the #core-performance channel in Slack.