Performance Chat Summary: 20 June 2023
Meeting agenda here and the full chat log is available beginning here on Slack.
Announcements
- Welcome to our new members of #core-performance [Slack thread]
- Release 2.4.0 scheduled for later today
- Agreed to postpone this to Tuesday June 20 to support several team members being out for the US holiday
- Upcoming Beta 1 for the 6.3 release on Tuesday June 27, 2023
- Updates to our Core Performance Handbook with the introduction of the Profiling PHP performance with XHProf article
class=”wp-block-heading” id=”focus-group-updates”>Priority Projects
Server Response Time
Contributors: @joemcgill @spacedmonkey @aristath
- @spacedmonkey:
- Committed
- https://github.com/WordPress/wordpress-develop/commit/3e2121c83de37335bcda944a09c2d1a8f11dab7b
- https://github.com/WordPress/wordpress-develop/commit/ea0a4881aeaa97c09bdab0ba7d3895dc29ea6247
- https://github.com/WordPress/wordpress-develop/commit/a14bc9b298b59c9d05f36038358e0a1ea5087c32
- https://github.com/WordPress/gutenberg/pull/50636
- Near commit
- In need of code review
- New tickets created
- Committed
Database Optimization
Contributors: @aristath @spacedmonkey @olliejones
- No updates this week
JavaScript & CSS
Contributors: @mukesh27 @10upsimon @adamsilverstein @westonruter
- @joemcgill For Script Loading Strategy: https://core.trac.wordpress.org/ticket/12009
- Most of the PR for adding support for `async` and `defer` has been approved for commit. Unfortunately, keeping in support for inline scripts is blocking the current PR, so we’re going to remove that part of the implementation this week and commit the rest. This just means that if anyone tries to add an `async` or `defer` strategy to a handle that has an inline script attached in an `after` position, the original script will be loaded with a blocking strategy instead.
- @spacedmonkey I code reviewed the above and approved it for commit
- @joemcgill we will likely ask for another review once we’ve implemented the changes
- @10upsimon Nothing more from my side, I’ll be working with @joemcgill on the reversal of delayed after inline scripts, and further testing
- @spacedmonkey Should we talk about the comment – https://github.com/WordPress/wordpress-develop/pull/4391#issuecomment-1598421109 . Or leave it open floor. I think this should be in core and I want to work out a path to unblock it
- @10upsimon this is the same level of push back we’re receiving on the Trac ticket itself. It’s a long standing aversion to support delayed inline scripts. I’d like to see it in core as well, if possible.
- @joemcgill I think we’ve exhausted this conversation for now. The focus this week should be to get the majority of this feature committed and we can advocate for extending support for inline scripts during the beta period.
- @spacedmonkey Could it be commit before the beta and then if we can resolve the inline style stuff, then we can do a part revert?
- @joemcgill Andrew has indicated in the PR thread that we could continue that conversation during the beta period, yes
Images
Contributors: @flixos90 @thekt12 @adamsilverstein @joemcgill
- @adamsilverstein Some recent developments on the modern image front: the new version of Safari includes JpegXL support which was a bit of a surprise and somewhat exciting. If other browsers follow suit, maybe the format will become useful for the web and WordPress?! In addition, Edge canary has apparently added AVIF support, so we will hopefully see all major browsers supporting AVIF soon. I created a patch to add AVIF support to core on the existing ticket that is ready for testing – https://core.trac.wordpress.org/ticket/51228
- @thekt12 and @flixos90 are also working on finalising https://github.com/WordPress/wordpress-develop/pull/4495 this week
- @spacedmonkey I have been code review and profiling this. We are awaiting a new version that improves PHP performance.
Measurement
Contributors: @adamsilverstein @olliejones @joemcgill @mukesh27
- @joemcgill Over the weekend, the Theme Unit Test data that we rely on briefly went offline and broke the automated performance tests in Core. There is an open ticket about bringing that code directly into our repo, rather than relying on the Theme Unit Test data, but there is also conversation happening about moving all of that code into the WP organization. Original thread: https://wordpress.slack.com/archives/C02RQBWTW/p1687140431658569 For now, I don’t think we need to take immediate action, but is something to consider over the coming weeks.
Ecosystem Tools
Contributors: @joegrainger @mukesh27
- @joegrainger We are working on the last check for Milestone 2 for the Plugin Checker. Once complete we’ll be moving onto further QA/Testing and remediating over this week and next. Progress can be seen on the GitHub repo here. Feel free to take a look and leave any thoughts/ideas you may have in the repo. Thanks!
Creating Standalone Plugins
Contributors: @flixos90 @mukesh27 @10upsimon
- @flixos90 Still awaiting approval of the Dominant Color Images plugin in the plugin repo
Open Floor
- @spacedmonkey This ticket has been very active – https://core.trac.wordpress.org/ticket/58368
- TLDR, WP_Commey_Query does count queries using order by, resulting in bad performance. Comment type is not a database index.
- @joemcgill That ticket needs an owner and and agreed upon patch in the next week. Seems like a stretch at the moment.
- @spacedmonkey I am not sure we can add indexes easily to a table like comments. The person on the ticket has 5 million comments in this database. Adding an index normally locks a table on a high traffic like that, it could be a problem. I think we will have to punt to 6.4. I will update the ticket.
- @rmccue I think we’ve added indexes on large tables before, seem to recall .com needing to orchestrate a slow rollout of them
- @joemcgill Do we know who is ensuring the fix for https://core.trac.wordpress.org/ticket/58457 is getting synced from the Gutenberg repo? This process still seems very manual and error prone to me.
- @spacedmonkey Do you mean – https://github.com/WordPress/gutenberg/pull/50266?
- @flixos90
- There’s a PR already, give me a sec. Needs review: https://github.com/WordPress/wordpress-develop/pull/4380
- @joemcgill That ticket seems to include references to two Gutenberg PRs, and a newly updated patch on that ticket. It would be good to have someone making sure that all of this gets resolved correctly.
- @flixos90 I hadn’t seen that ticket. Seems like the reporter found the same issue but fixed it in a different way. The patches on that ticket are effectively obsolete if my above PR is committed. I’ll leave a comment
- @spacedmonkey Would useful to get eyes on – https://github.com/WordPress/gutenberg/pull/51116
Our next chat will be held on Tuesday, June 27, 2023 at 15:00 UTC in the #core-performance channel in Slack.
